dracut: write initramfs to temp file then move into place
authorLars R. Damerow <lars@pixar.com>
Thu, 21 Feb 2013 21:40:23 +0000 (13:40 -0800)
committerHarald Hoyer <harald@redhat.com>
Fri, 22 Feb 2013 10:05:29 +0000 (11:05 +0100)
We've been finding cases where multiple instances of dracut can be launched
simultaneously, resulting in a corrupted initramfs file. This patch makes
dracut write the initramfs to a new file, then move it into place atomically.

dracut.sh

index 31cf2a5..da96aaa 100755 (executable)
--- a/dracut.sh
+++ b/dracut.sh
@@ -1103,10 +1103,11 @@ fi
 rm -f "$outfile"
 dinfo "*** Creating image file ***"
 if ! ( umask 077; cd "$initdir"; find . |cpio -R 0:0 -H newc -o --quiet| \
-    $compress > "$outfile"; ); then
-    dfatal "dracut: creation of $outfile failed"
+    $compress > "$outfile.$$"; ); then
+    dfatal "dracut: creation of $outfile.$$ failed"
     exit 1
 fi
+mv $outfile.$$ $outfile
 dinfo "*** Creating image file done ***"
 
 dinfo "Wrote $outfile:"