rpm: simplify the SrcRpmFile class a bit
authorMarkus Lehtonen <markus.lehtonen@linux.intel.com>
Wed, 21 Nov 2012 11:42:33 +0000 (13:42 +0200)
committerMarkus Lehtonen <markus.lehtonen@linux.intel.com>
Tue, 7 Jan 2014 14:21:29 +0000 (16:21 +0200)
Get rid of the unnecessary private methods.

Signed-off-by: Markus Lehtonen <markus.lehtonen@linux.intel.com>
gbp/rpm/__init__.py

index 24a9d1314a4dab5ba928c60c8cdb3f55d2e9a89b..40add0b64b7f9b6d110c7d1b83cf8b8e5dea86f5 100644 (file)
@@ -77,37 +77,29 @@ class SrcRpmFile(object):
         srpmfp.close()
         self.srpmfile = os.path.abspath(srpmfile)
 
-    def _get_version(self):
-        """
-        Get the (downstream) version of the RPM
-        """
+    @property
+    def version(self):
+        """Get the (downstream) version of the RPM package"""
         version = dict(upstreamversion = self.rpmhdr[rpm.RPMTAG_VERSION],
                        release = self.rpmhdr[rpm.RPMTAG_RELEASE])
         if self.rpmhdr[rpm.RPMTAG_EPOCH] is not None:
             version['epoch'] = str(self.rpmhdr[rpm.RPMTAG_EPOCH])
         return version
-    version = property(_get_version)
 
-    def _get_name(self):
-        """
-        Get the name of the RPM package
-        """
+    @property
+    def name(self):
+        """Get the name of the RPM package"""
         return self.rpmhdr[rpm.RPMTAG_NAME]
-    name = property(_get_name)
 
-    def _get_upstream_version(self):
-        """
-        Get the upstream version of the package
-        """
+    @property
+    def upstreamversion(self):
+        """Get the upstream version of the RPM package"""
         return self.rpmhdr[rpm.RPMTAG_VERSION]
-    upstreamversion = property(_get_upstream_version)
 
-    def _get_packager(self):
-        """
-        Get the packager of the RPM package
-        """
+    @property
+    def packager(self):
+        """Get the packager of the RPM package"""
         return self.rpmhdr[rpm.RPMTAG_PACKAGER]
-    packager = property(_get_packager)
 
     def unpack(self, dest_dir):
         """