[mlir] Hotfix - Fix Windows build
authorNicolas Vasilache <ntv@google.com>
Tue, 3 Mar 2020 03:47:16 +0000 (22:47 -0500)
committerNicolas Vasilache <ntv@google.com>
Tue, 3 Mar 2020 14:27:33 +0000 (09:27 -0500)
This revision adds a static `mlir_c_runner_utils_static` library
for the sole purpose of being linked into `mlir_runner_utils` on
Windows.

It was previously reported that:
```

`add_llvm_library(mlir_c_runner_utils SHARED CRunnerUtils.cpp)`

produces *only* a dll on windows, the linking of mlir_runner_utils fails
because target_link_libraries is looking for a .lib file as opposed to a
.dll file. I think this may be a case where either we need to use
LINK_LIBS or explicitly build a static lib as well, but I haven't tried
either yet.
```

mlir/lib/ExecutionEngine/CMakeLists.txt

index dc20e5f..37df716 100644 (file)
@@ -36,11 +36,12 @@ target_link_libraries(MLIRExecutionEngine
   ${outlibs})
 
 add_llvm_library(mlir_c_runner_utils SHARED CRunnerUtils.cpp)
+add_llvm_library(mlir_c_runner_utils_static CRunnerUtils.cpp)
 target_compile_definitions(mlir_c_runner_utils PRIVATE mlir_c_runner_utils_EXPORTS)
 
 add_llvm_library(mlir_runner_utils SHARED RunnerUtils.cpp)
 target_link_libraries(mlir_runner_utils
 
-  mlir_c_runner_utils
+  mlir_c_runner_utils_static
 )
 target_compile_definitions(mlir_runner_utils PRIVATE mlir_runner_utils_EXPORTS)