net: ksz884x: remove unused change variable
authorTom Rix <trix@redhat.com>
Wed, 29 Mar 2023 12:59:29 +0000 (08:59 -0400)
committerJakub Kicinski <kuba@kernel.org>
Fri, 31 Mar 2023 06:18:48 +0000 (23:18 -0700)
clang with W=1 reports
drivers/net/ethernet/micrel/ksz884x.c:3216:6: error: variable
  'change' set but not used [-Werror,-Wunused-but-set-variable]
        int change = 0;
            ^
This variable is not used so remove it.

Signed-off-by: Tom Rix <trix@redhat.com>
Reviewed-by: Simon Horman <simon.horman@corigine.com>
Link: https://lore.kernel.org/r/20230329125929.1808420-1-trix@redhat.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/micrel/ksz884x.c

index e6acd1e..f78e8ea 100644 (file)
@@ -3213,7 +3213,6 @@ static void port_get_link_speed(struct ksz_port *port)
        u8 remote;
        int i;
        int p;
-       int change = 0;
 
        interrupt = hw_block_intr(hw);
 
@@ -3260,17 +3259,14 @@ static void port_get_link_speed(struct ksz_port *port)
                                        port_cfg_back_pressure(hw, p,
                                                (1 == info->duplex));
                                }
-                               change |= 1 << i;
                                port_cfg_change(hw, port, info, status);
                        }
                        info->state = media_connected;
                } else {
-                       if (media_disconnected != info->state) {
-                               change |= 1 << i;
-
-                               /* Indicate the link just goes down. */
+                       /* Indicate the link just goes down. */
+                       if (media_disconnected != info->state)
                                hw->port_mib[p].link_down = 1;
-                       }
+
                        info->state = media_disconnected;
                }
                hw->port_mib[p].state = (u8) info->state;