staging: rtl8188eu: remove all DBG_88E calls from core/rtw_efuse.c
authorPhillip Potter <phil@philpotter.co.uk>
Tue, 15 Jun 2021 00:14:40 +0000 (01:14 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 15 Jun 2021 11:56:10 +0000 (13:56 +0200)
Remove all DBG_88E calls from core/rtw_efuse.c as this macro is
unnecessary, and many of these calls are dubious in terms of necessity.
Removing all calls will ultimately allow the removal of the macro
itself.

Signed-off-by: Phillip Potter <phil@philpotter.co.uk>
Link: https://lore.kernel.org/r/20210615001507.1171-2-phil@philpotter.co.uk
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/rtl8188eu/core/rtw_efuse.c

index 9bb3ec0..0d51bf9 100644 (file)
@@ -91,10 +91,8 @@ efuse_phymap_to_logical(u8 *phymap, u16 _offset, u16 _size_byte, u8  *pbuf)
        tmp = kcalloc(EFUSE_MAX_SECTION_88E,
                      sizeof(void *) + EFUSE_MAX_WORD_UNIT * sizeof(u16),
                      GFP_KERNEL);
-       if (!tmp) {
-               DBG_88E("%s: alloc eFuseWord fail!\n", __func__);
+       if (!tmp)
                goto eFuseWord_failed;
-       }
        for (i = 0; i < EFUSE_MAX_SECTION_88E; i++)
                tmp[i] = ((char *)(tmp + EFUSE_MAX_SECTION_88E)) + i * EFUSE_MAX_WORD_UNIT * sizeof(u16);
        eFuseWord = (u16 **)tmp;
@@ -113,7 +111,6 @@ efuse_phymap_to_logical(u8 *phymap, u16 _offset, u16 _size_byte, u8  *pbuf)
                efuse_utilized++;
                eFuse_Addr++;
        } else {
-               DBG_88E("EFUSE is empty efuse_Addr-%d efuse_data =%x\n", eFuse_Addr, rtemp8);
                goto exit;
        }
 
@@ -220,8 +217,6 @@ static void efuse_read_phymap_from_txpktbuf(
        if (bcnhead < 0) /* if not valid */
                bcnhead = usb_read8(adapter, REG_TDECTRL + 1);
 
-       DBG_88E("%s bcnhead:%d\n", __func__, bcnhead);
-
        usb_write8(adapter, REG_PKT_BUFF_ACCESS_CTRL, TXPKT_BUF_SELECT);
 
        dbg_addr = bcnhead * 128 / 8; /* 8-bytes addressing */
@@ -232,10 +227,8 @@ static void efuse_read_phymap_from_txpktbuf(
                usb_write8(adapter, REG_TXPKTBUF_DBG, 0);
                start = jiffies;
                while (!(reg_0x143 = usb_read8(adapter, REG_TXPKTBUF_DBG)) &&
-                      jiffies_to_msecs(jiffies - start) < 1000) {
-                       DBG_88E("%s polling reg_0x143:0x%02x, reg_0x106:0x%02x\n", __func__, reg_0x143, usb_read8(adapter, 0x106));
+                      jiffies_to_msecs(jiffies - start) < 1000)
                        usleep_range(1000, 2000);
-               }
 
                lo32 = usb_read32(adapter, REG_PKTBUF_DBG_DATA_L);
                hi32 = usb_read32(adapter, REG_PKTBUF_DBG_DATA_H);
@@ -255,8 +248,6 @@ static void efuse_read_phymap_from_txpktbuf(
 
                        limit = min_t(u16, len - 2, limit);
 
-                       DBG_88E("%s len:%u, lenbak:%u, aaa:%u, aaabak:%u\n", __func__, len, lenbak, aaa, aaabak);
-
                        memcpy(pos, ((u8 *)&lo32) + 2, (limit >= count + 2) ? 2 : limit - count);
                        count += (limit >= count + 2) ? 2 : limit - count;
                        pos = content + count;
@@ -278,7 +269,6 @@ static void efuse_read_phymap_from_txpktbuf(
                i++;
        }
        usb_write8(adapter, REG_PKT_BUFF_ACCESS_CTRL, DISABLE_TRXPKT_BUF_ACCESS);
-       DBG_88E("%s read count:%u\n", __func__, count);
        *size = count;
 }
 
@@ -432,7 +422,6 @@ int Efuse_PgPacketRead(struct adapter *pAdapter, u8 offset, u8 *data)
                                                hoffset = ((tmp_header & 0xE0) >> 5) | ((efuse_data & 0xF0) >> 1);
                                                hworden = efuse_data & 0x0F;
                                        } else {
-                                               DBG_88E("Error, All words disabled\n");
                                                efuse_addr++;
                                                continue;
                                        }