i2c: xlp9xx: Use dev_err_probe in probe function
authorLiao Chang <liaochang1@huawei.com>
Tue, 8 Aug 2023 01:29:48 +0000 (09:29 +0800)
committerAndi Shyti <andi.shyti@kernel.org>
Thu, 10 Aug 2023 08:12:55 +0000 (10:12 +0200)
Use the dev_err_probe function instead of dev_err in the probe function
so that the printed message includes the return value and also handles
-EPROBE_DEFER nicely.

Signed-off-by: Liao Chang <liaochang1@huawei.com>
Reviewed-by: Andi Shyti <andi.shyti@kernel.org>
Link: https://lore.kernel.org/r/20230808012954.1643834-4-liaochang1@huawei.com
Signed-off-by: Andi Shyti <andi.shyti@kernel.org>
drivers/i2c/busses/i2c-xlp9xx.c

index f59e8c5..08a59a9 100644 (file)
@@ -529,10 +529,8 @@ static int xlp9xx_i2c_probe(struct platform_device *pdev)
 
        err = devm_request_irq(&pdev->dev, priv->irq, xlp9xx_i2c_isr, 0,
                               pdev->name, priv);
-       if (err) {
-               dev_err(&pdev->dev, "IRQ request failed!\n");
-               return err;
-       }
+       if (err)
+               return dev_err_probe(&pdev->dev, err, "IRQ request failed!\n");
 
        init_completion(&priv->msg_complete);
        priv->adapter.dev.parent = &pdev->dev;