mmc: sdhci-esdhc-imx: fix return value check in sdhci_esdhc_imx_probe()
authorWei Yongjun <weiyongjun1@huawei.com>
Wed, 16 Jan 2019 05:44:51 +0000 (05:44 +0000)
committerUlf Hansson <ulf.hansson@linaro.org>
Mon, 25 Feb 2019 07:40:58 +0000 (08:40 +0100)
In case of error, the function devm_kzalloc() returns NULL pointer not
ERR_PTR(). The IS_ERR() test in the return value check should be
replaced with NULL test.

Fixes: fadac7488064 ("mmc: sdhci-esdhc-imx: add CMDQ support")
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Acked-by: Adrian Hunter <adrian.hunter@intel.com>
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
drivers/mmc/host/sdhci-esdhc-imx.c

index 75ad824..fad6007 100644 (file)
@@ -1500,8 +1500,8 @@ static int sdhci_esdhc_imx_probe(struct platform_device *pdev)
        if (imx_data->socdata->flags & ESDHC_FLAG_CQHCI) {
                host->mmc->caps2 |= MMC_CAP2_CQE | MMC_CAP2_CQE_DCMD;
                cq_host = devm_kzalloc(&pdev->dev, sizeof(*cq_host), GFP_KERNEL);
-               if (IS_ERR(cq_host)) {
-                       err = PTR_ERR(cq_host);
+               if (!cq_host) {
+                       err = -ENOMEM;
                        goto disable_ahb_clk;
                }