media: mt9m111: No need to check for the regulator
authorSakari Ailus <sakari.ailus@linux.intel.com>
Fri, 31 May 2019 20:11:35 +0000 (16:11 -0400)
committerMauro Carvalho Chehab <mchehab+samsung@kernel.org>
Mon, 24 Jun 2019 15:11:43 +0000 (11:11 -0400)
The regulator_get() function returns a regulator when it succeeds. There's
no need to check whether the regulator is NULL later on.

Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Reviewed-by: Marco Felsch <m.felsch@pengutronix.de>
Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
drivers/media/i2c/mt9m111.c

index 746d134..bb19f8c 100644 (file)
@@ -984,11 +984,9 @@ static int mt9m111_power_on(struct mt9m111 *mt9m111)
        if (ret < 0)
                return ret;
 
-       if (mt9m111->regulator) {
-               ret = regulator_enable(mt9m111->regulator);
-               if (ret < 0)
-                       return ret;
-       }
+       ret = regulator_enable(mt9m111->regulator);
+       if (ret < 0)
+               return ret;
 
        ret = mt9m111_resume(mt9m111);
        if (ret < 0) {
@@ -1002,8 +1000,7 @@ static int mt9m111_power_on(struct mt9m111 *mt9m111)
 static void mt9m111_power_off(struct mt9m111 *mt9m111)
 {
        mt9m111_suspend(mt9m111);
-       if (mt9m111->regulator)
-               regulator_disable(mt9m111->regulator);
+       regulator_disable(mt9m111->regulator);
        v4l2_clk_disable(mt9m111->clk);
 }