drm/i915/gt: Enable read back on XEHP_FF_MODE2
authorLucas De Marchi <lucas.demarchi@intel.com>
Fri, 30 Jun 2023 20:35:07 +0000 (13:35 -0700)
committerLucas De Marchi <lucas.demarchi@intel.com>
Mon, 3 Jul 2023 18:30:25 +0000 (11:30 -0700)
Contrary to GEN12_FF_MODE2, platforms using XEHP_FF_MODE2 are not
affected by Wa_1608008084, hence read back can be enabled.

Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
Reviewed-by: Kenneth Graunke <kenneth@whitecape.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20230630203509.1635216-6-lucas.demarchi@intel.com
drivers/gpu/drm/i915/gt/intel_workarounds.c

index b07f84c..e2025c3 100644 (file)
@@ -683,11 +683,8 @@ static void dg2_ctx_gt_tuning_init(struct intel_engine_cs *engine,
        wa_mcr_masked_en(wal, CHICKEN_RASTER_2, TBIMR_FAST_CLIP);
        wa_mcr_write_clr_set(wal, XEHP_L3SQCREG5, L3_PWM_TIMER_INIT_VAL_MASK,
                             REG_FIELD_PREP(L3_PWM_TIMER_INIT_VAL_MASK, 0x7f));
-       wa_mcr_add(wal,
-                  XEHP_FF_MODE2,
-                  FF_MODE2_TDS_TIMER_MASK,
-                  FF_MODE2_TDS_TIMER_128,
-                  0, false);
+       wa_mcr_write_clr_set(wal, XEHP_FF_MODE2, FF_MODE2_TDS_TIMER_MASK,
+                            FF_MODE2_TDS_TIMER_128);
 }
 
 static void gen12_ctx_workarounds_init(struct intel_engine_cs *engine,