serial: ifx6x60: Remove dangerous spi_driver casts
authorGeert Uytterhoeven <geert@linux-m68k.org>
Thu, 23 Apr 2015 14:15:39 +0000 (16:15 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 6 May 2015 20:27:01 +0000 (22:27 +0200)
Casting spi_driver pointers to "void *" when calling
spi_{,un}register_driver() bypasses all type checking.

Remove the superfluous casts to fix this.

Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/tty/serial/ifx6x60.c

index 5903909..7d858a7 100644 (file)
@@ -1381,7 +1381,7 @@ static void __exit ifx_spi_exit(void)
        /* unregister */
        tty_unregister_driver(tty_drv);
        put_tty_driver(tty_drv);
-       spi_unregister_driver((void *)&ifx_spi_driver);
+       spi_unregister_driver(&ifx_spi_driver);
        unregister_reboot_notifier(&ifx_modem_reboot_notifier_block);
 }
 
@@ -1420,7 +1420,7 @@ static int __init ifx_spi_init(void)
                goto err_free_tty;
        }
 
-       result = spi_register_driver((void *)&ifx_spi_driver);
+       result = spi_register_driver(&ifx_spi_driver);
        if (result) {
                pr_err("%s: spi_register_driver failed(%d)",
                        DRVNAME, result);
@@ -1436,7 +1436,7 @@ static int __init ifx_spi_init(void)
 
        return 0;
 err_unreg_spi:
-       spi_unregister_driver((void *)&ifx_spi_driver);
+       spi_unregister_driver(&ifx_spi_driver);
 err_unreg_tty:
        tty_unregister_driver(tty_drv);
 err_free_tty: