mmc: sunxi: Enable the new timings for the A64 MMC controllers
authorMaxime Ripard <maxime.ripard@free-electrons.com>
Fri, 27 Jan 2017 21:38:36 +0000 (22:38 +0100)
committerUlf Hansson <ulf.hansson@linaro.org>
Mon, 13 Feb 2017 12:20:50 +0000 (13:20 +0100)
The A64 MMC controllers need to set a "new timings" bit when a new rate is
set.

The actual meaning of that bit is not clear yet, but not setting it leads
to some corner-case issues, like the CMD53 failing, which is used to
implement SDIO packet aggregation.

Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com>
Tested-by: Florian Vaussard <florian.vaussard@heig-vd.ch>
Acked-by: Chen-Yu Tsai <wens@csie.org>
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
drivers/mmc/host/sunxi-mmc.c

index b9c8a62..51d6388 100644 (file)
@@ -253,6 +253,8 @@ struct sunxi_mmc_cfg {
 
        /* does the IP block support autocalibration? */
        bool can_calibrate;
+
+       bool needs_new_timings;
 };
 
 struct sunxi_mmc_host {
@@ -779,6 +781,9 @@ static int sunxi_mmc_clk_set_rate(struct sunxi_mmc_host *host,
        }
        mmc_writel(host, REG_CLKCR, rval);
 
+       if (host->cfg->needs_new_timings)
+               mmc_writel(host, REG_SD_NTSR, SDXC_2X_TIMING_MODE);
+
        ret = sunxi_mmc_clk_set_phase(host, ios, rate);
        if (ret)
                return ret;
@@ -1076,6 +1081,7 @@ static const struct sunxi_mmc_cfg sun50i_a64_cfg = {
        .idma_des_size_bits = 16,
        .clk_delays = NULL,
        .can_calibrate = true,
+       .needs_new_timings = true,
 };
 
 static const struct of_device_id sunxi_mmc_of_match[] = {