media: i2c: imx412: Fix power_off ordering
authorBryan O'Donoghue <bryan.odonoghue@linaro.org>
Fri, 15 Apr 2022 11:59:52 +0000 (13:59 +0200)
committerMauro Carvalho Chehab <mchehab@kernel.org>
Tue, 17 May 2022 07:07:21 +0000 (09:07 +0200)
The enable path does
- gpio
- clock

The disable path does
- gpio
- clock

Fix the order on the power-off path so that power-off and power-on have the
same ordering for clock and gpio.

Fixes: 9214e86c0cc1 ("media: i2c: Add imx412 camera sensor driver")
Cc: stable@vger.kernel.org
Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
Reviewed-by: Jacopo Mondi <jacopo@jmondi.org>
Reviewed-by: Daniele Alessandrelli <daniele.alessandrelli@intel.com>
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>
drivers/media/i2c/imx412.c

index e6be6b4..84279a6 100644 (file)
@@ -1040,10 +1040,10 @@ static int imx412_power_off(struct device *dev)
        struct v4l2_subdev *sd = dev_get_drvdata(dev);
        struct imx412 *imx412 = to_imx412(sd);
 
-       gpiod_set_value_cansleep(imx412->reset_gpio, 1);
-
        clk_disable_unprepare(imx412->inclk);
 
+       gpiod_set_value_cansleep(imx412->reset_gpio, 1);
+
        return 0;
 }