2010-08-25 Ivan Maidanski <ivmai@mail.ru> (with help from Hans Boehm)

	* dyn_load.c (GC_register_dynlib_callback): Add FIXME.

diff --git a/ChangeLog b/ChangeLog
index 20373dd..07a214a 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,7 @@
+2010-08-25  Ivan Maidanski <ivmai@mail.ru> (with help from Hans Boehm)
+
+       * dyn_load.c (GC_register_dynlib_callback): Add FIXME.
+
 2010-08-18  Ivan Maidanski <ivmai@mail.ru> (really Andreas Tobler)
 
        * include/private/gcconfig.h: Add support for FreeBSD on ppc64.

diff --git a/dyn_load.c b/dyn_load.c
index e1f7ed4..eab59ff 100644 (file)
--- a/dyn_load.c
+++ b/dyn_load.c
@@ -486,6 +486,10 @@ STATIC int GC_register_dynlib_callback(struct dl_phdr_info * info,
 #         ifdef PT_GNU_RELRO
             if (n_load_segs >= MAX_LOAD_SEGS) ABORT("Too many PT_LOAD segs");
 #           if CPP_WORDSZ == 64
+              /* FIXME: GC_push_all eventually does the correct         */
+              /* rounding to the next multiple of ALIGNMENT, so, most   */
+              /* probably, we should remove the corresponding assertion */
+              /* check in GC_add_roots_inner along with this code line. */
               /* start pointer value may require aligning */
               start = (ptr_t)((word)start & ~(sizeof(word) - 1));
 #           endif