drm/atmel-hlcdc: Remove redundant calls to drm_connector_register_all()
authorChris Wilson <chris@chris-wilson.co.uk>
Fri, 17 Jun 2016 08:25:19 +0000 (09:25 +0100)
committerDaniel Vetter <daniel.vetter@ffwll.ch>
Tue, 21 Jun 2016 08:53:12 +0000 (10:53 +0200)
Up to now, the recommendation was for drivers to call drm_dev_register()
followed by drm_connector_register_all(). Now that
drm_connector_register() is safe against multiple invocations, we can
move drm_connector_register_all() to drm_dev_register() and not suffer
from any backwards compatibility issues with drivers not following the
more rigorous init ordering.

Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: Boris Brezillon <boris.brezillon@free-electrons.com>
Cc: David Airlie <airlied@linux.ie>
Cc: dri-devel@lists.freedesktop.org
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Link: http://patchwork.freedesktop.org/patch/msgid/1466151923-1572-4-git-send-email-chris@chris-wilson.co.uk
drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c

index 9ecf16c..99c4af6 100644 (file)
@@ -815,15 +815,8 @@ static int atmel_hlcdc_dc_drm_probe(struct platform_device *pdev)
        if (ret)
                goto err_unload;
 
-       ret = drm_connector_register_all(ddev);
-       if (ret)
-               goto err_unregister;
-
        return 0;
 
-err_unregister:
-       drm_dev_unregister(ddev);
-
 err_unload:
        atmel_hlcdc_dc_unload(ddev);