dmaengine: idxd: Fix missing error code in idxd_cdev_open()
authorJiapeng Chong <jiapeng.chong@linux.alibaba.com>
Wed, 2 Jun 2021 10:07:26 +0000 (18:07 +0800)
committerVinod Koul <vkoul@kernel.org>
Thu, 3 Jun 2021 06:58:37 +0000 (12:28 +0530)
The error code is missing in this code scenario, add the error code
'-EINVAL' to the return value 'rc'.

Eliminate the follow smatch warning:

drivers/dma/idxd/cdev.c:113 idxd_cdev_open() warn: missing error code
'rc'.

Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
Acked-by: Dave Jiang <dave.jiang@intel.com>
Link: https://lore.kernel.org/r/1622628446-87909-1-git-send-email-jiapeng.chong@linux.alibaba.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>
drivers/dma/idxd/cdev.c

index 302cba5ff779d751859fd3a81de9f696b419482c..d4419bf1fedefe067a763172cd3f1c1f3cfe8b6e 100644 (file)
@@ -110,6 +110,7 @@ static int idxd_cdev_open(struct inode *inode, struct file *filp)
                pasid = iommu_sva_get_pasid(sva);
                if (pasid == IOMMU_PASID_INVALID) {
                        iommu_sva_unbind_device(sva);
+                       rc = -EINVAL;
                        goto failed;
                }