misc: sgi-xp: remove meaningless null check before kfree
authorzhong jiang <zhongjiang@huawei.com>
Fri, 17 Aug 2018 03:42:35 +0000 (11:42 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 14 Sep 2018 13:36:20 +0000 (15:36 +0200)
kfree has taken null pointer into account. so check the null pointer
before kfree is meaningless.

Signed-off-by: zhong jiang <zhongjiang@huawei.com>
Acked-by: Robin Holt <robinmholt@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/misc/sgi-xp/xpc_partition.c

index 0c3ef6f..3eba1c4 100644 (file)
@@ -98,8 +98,7 @@ xpc_get_rsvd_page_pa(int nasid)
                        len = L1_CACHE_ALIGN(len);
 
                if (len > buf_len) {
-                       if (buf_base != NULL)
-                               kfree(buf_base);
+                       kfree(buf_base);
                        buf_len = L1_CACHE_ALIGN(len);
                        buf = xpc_kmalloc_cacheline_aligned(buf_len, GFP_KERNEL,
                                                            &buf_base);