Fix pipe resize failure being considered an error 95/193795/2
authorMichal Bloch <m.bloch@samsung.com>
Mon, 26 Nov 2018 11:00:57 +0000 (12:00 +0100)
committerHyotaek Shim <hyotaek.shim@samsung.com>
Tue, 27 Nov 2018 02:29:22 +0000 (02:29 +0000)
Pipes are enlarged so that prolific logging does not clog the pipe,
which is just an optimisation - logging can still continue if it
fails (albeit slower).

Change-Id: I5218512d3b22eea1636460ed463eeb2280faa9e7
Signed-off-by: Michal Bloch <m.bloch@samsung.com>
src/logger/logger.c

index 7f261e1..c12dac4 100644 (file)
@@ -1438,9 +1438,8 @@ static int service_writer_handle_req_pipe(struct logger* server, struct writer*
                return -errno;
        }
 
-       r = fcntl(pipe_fd[1], F_SETPIPE_SZ, PIPE_REQUESTED_SIZE);
-       if (r < 0)
-               goto err_close;
+       // no big deal if this fails; just an optimisation
+       fcntl(pipe_fd[1], F_SETPIPE_SZ, PIPE_REQUESTED_SIZE);
 
        assert(server);
        assert(wr);