af_unix: call proto_unregister() in the error path in af_unix_init()
authorYang Yingliang <yangyingliang@huawei.com>
Thu, 8 Dec 2022 15:01:58 +0000 (23:01 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 31 Dec 2022 12:32:27 +0000 (13:32 +0100)
[ Upstream commit 73e341e0281a35274629e9be27eae2f9b1b492bf ]

If register unix_stream_proto returns error, unix_dgram_proto needs
be unregistered.

Fixes: 94531cfcbe79 ("af_unix: Add unix_stream_proto for sockmap")
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Reviewed-by: Simon Horman <simon.horman@corigine.com>
Reviewed-by: Kuniyuki Iwashima <kuniyu@amazon.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>
net/unix/af_unix.c

index b3545fc..ede2b2a 100644 (file)
@@ -3738,6 +3738,7 @@ static int __init af_unix_init(void)
        rc = proto_register(&unix_stream_proto, 1);
        if (rc != 0) {
                pr_crit("%s: Cannot create unix_sock SLAB cache!\n", __func__);
+               proto_unregister(&unix_dgram_proto);
                goto out;
        }