power: supply: sbs-battery: use correct flags field
authorMichael Nosthoff <committed@heine.so>
Fri, 16 Aug 2019 07:37:42 +0000 (09:37 +0200)
committerSebastian Reichel <sre@kernel.org>
Mon, 2 Sep 2019 08:06:23 +0000 (10:06 +0200)
the type flag is stored in the chip->flags field not in the
client->flags field. This currently leads to never using the ti
specific health function as client->flags doesn't use that bit.
So it's always falling back to the general one.

Fixes: 76b16f4cdfb8 ("power: supply: sbs-battery: don't assume MANUFACTURER_DATA formats")
Cc: <stable@vger.kernel.org>
Signed-off-by: Michael Nosthoff <committed@heine.so>
Reviewed-by: Brian Norris <briannorris@chromium.org>
Reviewed-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
drivers/power/supply/sbs-battery.c

index 048d205..2e86cc1 100644 (file)
@@ -620,7 +620,7 @@ static int sbs_get_property(struct power_supply *psy,
        switch (psp) {
        case POWER_SUPPLY_PROP_PRESENT:
        case POWER_SUPPLY_PROP_HEALTH:
-               if (client->flags & SBS_FLAGS_TI_BQ20Z75)
+               if (chip->flags & SBS_FLAGS_TI_BQ20Z75)
                        ret = sbs_get_ti_battery_presence_and_health(client,
                                                                     psp, val);
                else