pinctrl: intel: Drop unnecessary check for predefined features
authorAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Thu, 7 Jan 2021 19:01:58 +0000 (21:01 +0200)
committerAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Fri, 8 Jan 2021 12:57:16 +0000 (14:57 +0200)
None of the drivers is overriding features. Remove unnecessary check.
While here, rename rev to value to make easier further development.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Acked-by: Mika Westerberg <mika.westerberg@linux.intel.com>
drivers/pinctrl/intel/pinctrl-intel.c

index ae13e43..1a47911 100644 (file)
@@ -1473,6 +1473,7 @@ static int intel_pinctrl_probe(struct platform_device *pdev,
                struct intel_community *community = &pctrl->communities[i];
                void __iomem *regs;
                u32 padbar;
+               u32 value;
 
                *community = pctrl->soc->communities[i];
 
@@ -1480,18 +1481,11 @@ static int intel_pinctrl_probe(struct platform_device *pdev,
                if (IS_ERR(regs))
                        return PTR_ERR(regs);
 
-               /*
-                * Determine community features based on the revision if
-                * not specified already.
-                */
-               if (!community->features) {
-                       u32 rev;
-
-                       rev = (readl(regs + REVID) & REVID_MASK) >> REVID_SHIFT;
-                       if (rev >= 0x94) {
-                               community->features |= PINCTRL_FEATURE_DEBOUNCE;
-                               community->features |= PINCTRL_FEATURE_1K_PD;
-                       }
+               /* Determine community features based on the revision */
+               value = readl(regs + REVID);
+               if (((value & REVID_MASK) >> REVID_SHIFT) >= 0x94) {
+                       community->features |= PINCTRL_FEATURE_DEBOUNCE;
+                       community->features |= PINCTRL_FEATURE_1K_PD;
                }
 
                /* Read offset of the pad configuration registers */