Fix coverity issue (Uninitialized pointer read)

[Version] 1.2-1
[Issue Type] Coverity

Change-Id: Ia74caa8f47ad10494f279e99ea72fe771a8efd5a
Signed-off-by: Jaechul Lee <jcsing.lee@samsung.com>

diff --git a/CMakeLists.txt b/CMakeLists.txt
index 095746a..96810f0 100644 (file)
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -20,8 +20,10 @@ endif()
 
 SET(EXTRA_CFLAGS "${EXTRA_CFLAGS} ${TIZEN_PKGS_CFLAGS}")
 
-SET(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -O3 -g -Wall -fPIC")
-SET(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -O3 -g -Wall -fPIC")
+SET(TIZEN_FEATURE_FLAGS "-DTIZEN_FEATURE_MODIFICATION")
+
+SET(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -O3 -g -Wall -fPIC ${TIZEN_FEATURE_FLAGS}")
+SET(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -O3 -g -Wall -fPIC ${TIZEN_FEATURE_FLAGS}")
 SET(CMAKE_EXE_LINKER_FLAGS "${CMAKE_EXE_LINKER_FLAGS} -Wl,--as-needed -pie -fPIC")
 SET(PKG_LDFLAGS "m")
 

diff --git a/packaging/noise-suppression.spec b/packaging/noise-suppression.spec
index c30612f..f3f380a 100644 (file)
--- a/packaging/noise-suppression.spec
+++ b/packaging/noise-suppression.spec
@@ -1,7 +1,7 @@
 Name: noise-suppression
 Summary: Acoustic noise suppression library
 Version: 1.2
-Release: 0
+Release: 1
 License: BSD-3-Clause
 Source0: %{name}-%{version}.tar.gz
 

diff --git a/src/kiss_fft.c b/src/kiss_fft.c
index 81e6163..d92803a 100644 (file)
--- a/src/kiss_fft.c
+++ b/src/kiss_fft.c
@@ -449,6 +449,9 @@ kiss_fft_state *opus_fft_alloc_twiddles(int nfft,void * mem,size_t * lenmem,
         kiss_twiddle_cpx *twiddles;
 
         st->nfft=nfft;
+#ifdef TIZEN_FEATURE_MODIFICATION
+        st->bitrev = NULL;
+#endif
 #ifdef FIXED_POINT
         st->scale_shift = celt_ilog2(st->nfft);
         if (st->nfft == 1<<st->scale_shift)
@@ -506,7 +509,10 @@ void opus_fft_free(const kiss_fft_state *cfg, int arch)
    if (cfg)
    {
       opus_fft_free_arch((kiss_fft_state *)cfg, arch);
-      opus_free((opus_int16*)cfg->bitrev);
+#ifdef TIZEN_FEATURE_MODIFICATION
+      if (cfg->bitrev)
+#endif
+         opus_free((opus_int16*)cfg->bitrev);
       if (cfg->shift < 0)
          opus_free((kiss_twiddle_cpx*)cfg->twiddles);
       opus_free((kiss_fft_state*)cfg);