scsi: esas2r: Drop PCI Wakeup calls from .resume
authorVaibhav Gupta <vaibhavgupta40@gmail.com>
Mon, 2 Nov 2020 16:47:11 +0000 (22:17 +0530)
committerMartin K. Petersen <martin.petersen@oracle.com>
Thu, 26 Nov 2020 04:14:30 +0000 (23:14 -0500)
The driver calls pci_enable_wake(...., false) in esas2r_resume(), and there
is no corresponding pci_enable_wake(...., true) in esas2r_suspend().
Either it should do enable-wake the device in .suspend() or should not
invoke pci_enable_wake() at all.

Concluding that this driver doesn't support enable-wake and PCI core calls
pci_enable_wake(pci_dev, PCI_D0, false) during resume, drop it from
esas2r_resume().

Link: https://lore.kernel.org/r/20201102164730.324035-11-vaibhavgupta40@gmail.com
Signed-off-by: Vaibhav Gupta <vaibhavgupta40@gmail.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/esas2r/esas2r_init.c

index 4b91db7..948bf33 100644 (file)
@@ -678,10 +678,6 @@ int esas2r_resume(struct pci_dev *pdev)
                       "called");
        pci_set_power_state(pdev, PCI_D0);
        esas2r_log_dev(ESAS2R_LOG_INFO, &(pdev->dev),
-                      "pci_enable_wake(PCI_D0, 0) "
-                      "called");
-       pci_enable_wake(pdev, PCI_D0, 0);
-       esas2r_log_dev(ESAS2R_LOG_INFO, &(pdev->dev),
                       "pci_restore_state() called");
        pci_restore_state(pdev);
        esas2r_log_dev(ESAS2R_LOG_INFO, &(pdev->dev),