hci_h5: Don't send conf_req when ACTIVE
authorPhil Elwell <phil@raspberrypi.org>
Thu, 17 Dec 2015 13:37:07 +0000 (13:37 +0000)
committerpopcornmix <popcornmix@gmail.com>
Mon, 13 May 2019 23:07:58 +0000 (00:07 +0100)
Without this patch, a modem and kernel can continuously bombard each
other with conf_req and conf_rsp messages, in a demented game of tag.

drivers/bluetooth/hci_h5.c

index 8eede11..20953e5 100644 (file)
@@ -352,7 +352,8 @@ static void h5_handle_internal_rx(struct hci_uart *hu)
                h5_link_control(hu, conf_req, 3);
        } else if (memcmp(data, conf_req, 2) == 0) {
                h5_link_control(hu, conf_rsp, 2);
-               h5_link_control(hu, conf_req, 3);
+               if (h5->state != H5_ACTIVE)
+                   h5_link_control(hu, conf_req, 3);
        } else if (memcmp(data, conf_rsp, 2) == 0) {
                if (H5_HDR_LEN(hdr) > 2)
                        h5->tx_win = (data[2] & 0x07);