staging: wfx: fix access to le32 attribute 'ps_mode_error'
authorJérôme Pouiller <jerome.pouiller@silabs.com>
Tue, 12 May 2020 15:04:05 +0000 (17:04 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 13 May 2020 11:49:43 +0000 (13:49 +0200)
The attribute ps_mode_error is little-endian. We have to take to the
endianness when we access it.

Signed-off-by: Jérôme Pouiller <jerome.pouiller@silabs.com>
Link: https://lore.kernel.org/r/20200512150414.267198-9-Jerome.Pouiller@silabs.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/wfx/hif_rx.c

index 83c3fdb..87d5107 100644 (file)
@@ -158,6 +158,7 @@ static int hif_event_indication(struct wfx_dev *wdev,
 {
        struct wfx_vif *wvif = wdev_to_wvif(wdev, hif->interface);
        const struct hif_ind_event *body = buf;
+       int cause;
 
        if (!wvif) {
                dev_warn(wdev->dev, "received event for non-existent vif\n");
@@ -176,10 +177,10 @@ static int hif_event_indication(struct wfx_dev *wdev,
                dev_dbg(wdev->dev, "ignore BSSREGAINED indication\n");
                break;
        case HIF_EVENT_IND_PS_MODE_ERROR:
+               cause = le32_to_cpu(body->event_data.ps_mode_error);
                dev_warn(wdev->dev, "error while processing power save request: %d\n",
-                        body->event_data.ps_mode_error);
-               if (body->event_data.ps_mode_error ==
-                   HIF_PS_ERROR_AP_NOT_RESP_TO_POLL) {
+                        cause);
+               if (cause == HIF_PS_ERROR_AP_NOT_RESP_TO_POLL) {
                        wvif->bss_not_support_ps_poll = true;
                        schedule_work(&wvif->update_pm_work);
                }