drm/amdgpu/swsmu/vangogh: Only use RLCPowerNotify msg for disable
authorAlex Deucher <alexander.deucher@amd.com>
Wed, 24 Feb 2021 20:46:59 +0000 (15:46 -0500)
committerAlex Deucher <alexander.deucher@amd.com>
Thu, 4 Mar 2021 03:50:26 +0000 (22:50 -0500)
Per discussions with PMFW team, the driver only needs to
notify the PMFW when the RLC is disabled.  The RLC FW will notify
the PMFW directly when it's enabled.

Acked-by: Evan Quan <evan.quan@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/pm/swsmu/smu11/vangogh_ppt.c

index d77e4a1..7ddbaec 100644 (file)
@@ -1685,9 +1685,9 @@ static int vangogh_system_features_control(struct smu_context *smu, bool en)
        uint32_t feature_mask[2];
        int ret = 0;
 
-       if (adev->pm.fw_version >= 0x43f1700)
+       if (adev->pm.fw_version >= 0x43f1700 && !en)
                ret = smu_cmn_send_smc_msg_with_param(smu, SMU_MSG_RlcPowerNotify,
-                                                     en ? RLC_STATUS_NORMAL : RLC_STATUS_OFF, NULL);
+                                                     RLC_STATUS_OFF, NULL);
 
        bitmap_zero(feature->enabled, feature->feature_num);
        bitmap_zero(feature->supported, feature->feature_num);