io_uring/net: ensure compat import handlers clear free_iov
authorJens Axboe <axboe@kernel.dk>
Mon, 19 Dec 2022 14:28:26 +0000 (07:28 -0700)
committerJens Axboe <axboe@kernel.dk>
Mon, 19 Dec 2022 14:35:16 +0000 (07:35 -0700)
If we're not allocating the vectors because the count is below
UIO_FASTIOV, we still do need to properly clear ->free_iov to prevent
an erronous free of on-stack data.

Reported-by: Jiri Slaby <jirislaby@gmail.com>
Fixes: 4c17a496a7a0 ("io_uring/net: fix cleanup double free free_iov init")
Cc: stable@vger.kernel.org
Signed-off-by: Jens Axboe <axboe@kernel.dk>
io_uring/net.c

index 5229976cb5829f8a5944a5bcb34f4175bd2c1bd8..f76b688f476e71d839dbc1fe7fc2fa39b1930f32 100644 (file)
@@ -494,6 +494,7 @@ static int __io_compat_recvmsg_copy_hdr(struct io_kiocb *req,
        if (req->flags & REQ_F_BUFFER_SELECT) {
                compat_ssize_t clen;
 
+               iomsg->free_iov = NULL;
                if (msg.msg_iovlen == 0) {
                        sr->len = 0;
                } else if (msg.msg_iovlen > 1) {