gpio: ks8695: Change to use DEFINE_SHOW_ATTRIBUTE macro
authorYangtao Li <tiny.windzz@gmail.com>
Fri, 30 Nov 2018 16:22:46 +0000 (11:22 -0500)
committerLinus Walleij <linus.walleij@linaro.org>
Fri, 7 Dec 2018 10:10:14 +0000 (11:10 +0100)
Use DEFINE_SHOW_ATTRIBUTE macro to simplify the code.

Signed-off-by: Yangtao Li <tiny.windzz@gmail.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
drivers/gpio/gpio-ks8695.c

index 55d562e..d6d6140 100644 (file)
@@ -282,22 +282,13 @@ static int ks8695_gpio_show(struct seq_file *s, void *unused)
        return 0;
 }
 
-static int ks8695_gpio_open(struct inode *inode, struct file *file)
-{
-       return single_open(file, ks8695_gpio_show, NULL);
-}
-
-static const struct file_operations ks8695_gpio_operations = {
-       .open           = ks8695_gpio_open,
-       .read           = seq_read,
-       .llseek         = seq_lseek,
-       .release        = single_release,
-};
+DEFINE_SHOW_ATTRIBUTE(ks8695_gpio);
 
 static int __init ks8695_gpio_debugfs_init(void)
 {
        /* /sys/kernel/debug/ks8695_gpio */
-       (void) debugfs_create_file("ks8695_gpio", S_IFREG | S_IRUGO, NULL, NULL, &ks8695_gpio_operations);
+       debugfs_create_file("ks8695_gpio", S_IFREG | S_IRUGO, NULL, NULL,
+                               &ks8695_gpio_fops);
        return 0;
 }
 postcore_initcall(ks8695_gpio_debugfs_init);