ethernet: i825xx: don't write directly to netdev->dev_addr
authorJakub Kicinski <kuba@kernel.org>
Wed, 26 Jan 2022 00:37:59 +0000 (16:37 -0800)
committerDavid S. Miller <davem@davemloft.net>
Wed, 26 Jan 2022 15:40:01 +0000 (15:40 +0000)
netdev->dev_addr is const now.

Compile tested rpc_defconfig w/ GCC 8.5.

Fixes: adeef3e32146 ("net: constify netdev->dev_addr")
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Reviewed-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/i825xx/ether1.c

index c612ef526d16d684d3546ec2f870fb3b9f079e89..3e7d7c4bafdc2dcaa1ad0435255ba1628db42d2e 100644 (file)
@@ -986,6 +986,7 @@ static int
 ether1_probe(struct expansion_card *ec, const struct ecard_id *id)
 {
        struct net_device *dev;
+       u8 addr[ETH_ALEN];
        int i, ret = 0;
 
        ether1_banner();
@@ -1015,7 +1016,8 @@ ether1_probe(struct expansion_card *ec, const struct ecard_id *id)
        }
 
        for (i = 0; i < 6; i++)
-               dev->dev_addr[i] = readb(IDPROM_ADDRESS + (i << 2));
+               addr[i] = readb(IDPROM_ADDRESS + (i << 2));
+       eth_hw_addr_set(dev, addr);
 
        if (ether1_init_2(dev)) {
                ret = -ENODEV;