iomap: set did_zero to true when zeroing successfully
authorKaixu Xia <kaixuxia@tencent.com>
Thu, 30 Jun 2022 17:04:18 +0000 (10:04 -0700)
committerDarrick J. Wong <djwong@kernel.org>
Thu, 30 Jun 2022 17:04:18 +0000 (10:04 -0700)
It is unnecessary to check and set did_zero value in while() loop
in iomap_zero_iter(), we can set did_zero to true only when zeroing
successfully at last.

Signed-off-by: Kaixu Xia <kaixuxia@tencent.com>
Reviewed-by: Chaitanya Kulkarni <kch@nvidia.com>
Reviewed-by: Darrick J. Wong <djwong@kernel.org>
Signed-off-by: Darrick J. Wong <djwong@kernel.org>
Reviewed-by: Christoph Hellwig <hch@lst.de>
fs/iomap/buffered-io.c

index 02b8bb4..afd2606 100644 (file)
@@ -917,10 +917,10 @@ static loff_t iomap_zero_iter(struct iomap_iter *iter, bool *did_zero)
                pos += bytes;
                length -= bytes;
                written += bytes;
-               if (did_zero)
-                       *did_zero = true;
        } while (length > 0);
 
+       if (did_zero)
+               *did_zero = true;
        return written;
 }