i3c: master: svc: fix SDA keep low when polling IBIWON timeout happen
authorFrank Li <Frank.Li@nxp.com>
Mon, 23 Oct 2023 16:16:57 +0000 (12:16 -0400)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 28 Nov 2023 17:20:06 +0000 (17:20 +0000)
commit dfd7cd6aafdb1f5ba93828e97e56b38304b23a05 upstream.

Upon IBIWON timeout, the SDA line will always be kept low if we don't emit
a stop. Calling svc_i3c_master_emit_stop() there will let the bus return to
idle state.

Fixes: dd3c52846d59 ("i3c: master: svc: Add Silvaco I3C master driver")
Cc: <stable@vger.kernel.org>
Reviewed-by: Miquel Raynal <miquel.raynal@bootlin.com>
Signed-off-by: Frank Li <Frank.Li@nxp.com>
Link: https://lore.kernel.org/r/20231023161658.3890811-6-Frank.Li@nxp.com
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/i3c/master/svc-i3c-master.c

index 23805db..2687112 100644 (file)
@@ -405,6 +405,7 @@ static void svc_i3c_master_ibi_work(struct work_struct *work)
                                         SVC_I3C_MSTATUS_IBIWON(val), 0, 1000);
        if (ret) {
                dev_err(master->dev, "Timeout when polling for IBIWON\n");
+               svc_i3c_master_emit_stop(master);
                goto reenable_ibis;
        }