gst/gstpad.c: Release pad lock before calling out to avoid a possible deadlock.

Original commit message from CVS:
* gst/gstpad.c: (gst_pad_peer_accept_caps):
Release pad lock before calling out to avoid a possible deadlock.

diff --git a/ChangeLog b/ChangeLog
index 8cdc4be..a7e7cb2 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,5 +1,10 @@
 2008-05-14  Wim Taymans  <wim.taymans@collabora.co.uk>
 
+       * gst/gstpad.c: (gst_pad_peer_accept_caps):
+       Release pad lock before calling out to avoid a possible deadlock.
+
+2008-05-14  Wim Taymans  <wim.taymans@collabora.co.uk>
+
        * gst/parse/grammar.y:
        Remove unneeded value unset.
 

diff --git a/gst/gstpad.c b/gst/gstpad.c
index 4a1fa5b..86d7d54 100644 (file)
--- a/gst/gstpad.c
+++ b/gst/gstpad.c
@@ -2327,9 +2327,14 @@ gst_pad_peer_accept_caps (GstPad * pad, GstCaps * caps)
   if (G_UNLIKELY (peerpad == NULL))
     goto no_peer;
 
-  result = gst_pad_accept_caps (peerpad, caps);
+  gst_object_ref (peerpad);
+  /* release lock before calling external methods but keep ref to pad */
   GST_OBJECT_UNLOCK (pad);
 
+  result = gst_pad_accept_caps (peerpad, caps);
+
+  gst_object_unref (peerpad);
+
   return result;
 
 no_peer: