ACPI/APEI: Clear GHES block_status before panic()
authorLenny Szubowicz <lszubowi@redhat.com>
Wed, 19 Dec 2018 16:50:52 +0000 (11:50 -0500)
committerRafael J. Wysocki <rafael.j.wysocki@intel.com>
Thu, 20 Dec 2018 20:35:45 +0000 (21:35 +0100)
In __ghes_panic() clear the block status in the APEI generic
error status block for that generic hardware error source before
calling panic() to prevent a second panic() in the crash kernel
for exactly the same fatal error.

Otherwise ghes_probe(), running in the crash kernel, would see
an unhandled error in the APEI generic error status block and
panic again, thereby precluding any crash dump.

Signed-off-by: Lenny Szubowicz <lszubowi@redhat.com>
Signed-off-by: David Arcari <darcari@redhat.com>
Tested-by: Tyler Baicar <baicar.tyler@gmail.com>
Acked-by: Borislav Petkov <bp@suse.de>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
drivers/acpi/apei/ghes.c

index 02c6fd9..f008ba7 100644 (file)
@@ -691,6 +691,8 @@ static void __ghes_panic(struct ghes *ghes)
 {
        __ghes_print_estatus(KERN_EMERG, ghes->generic, ghes->estatus);
 
+       ghes_clear_estatus(ghes);
+
        /* reboot to log the error! */
        if (!panic_timeout)
                panic_timeout = ghes_panic_timeout;