avoid redundant tests
authorOswald Buddenhagen <oswald.buddenhagen@nokia.com>
Wed, 2 May 2012 09:34:05 +0000 (11:34 +0200)
committerQt by Nokia <qt-info@nokia.com>
Fri, 1 Jun 2012 18:34:31 +0000 (20:34 +0200)
tryRun() already implies tryLink() and tryCompile(), so there is no
point in executing the stages separately ...

Change-Id: Id7321efaca474e8c5db2bc246ac26323d8a99e58
Reviewed-by: Thiago Macieira <thiago.macieira@intel.com>
tests/auto/corelib/tools/qsharedpointer/tst_qsharedpointer.cpp

index bb9be1d..506bab6 100644 (file)
@@ -1825,13 +1825,9 @@ void tst_QSharedPointer::invalidConstructs()
     QFETCH(QString, code);
     static bool sane = true;
     if (code.isEmpty()) {
-        static const char snippet[] = "QSharedPointer<Data> baseptr; QSharedPointer<DerivedData> ptr;";
-        if (!test.tryCompile("")
-            || !test.tryRun("")
+        if (!test.tryRun("")
             || !test.tryRunFail("exit(1);")
-            || !test.tryCompile(snippet)
-            || !test.tryLink(snippet)
-            || !test.tryRun(snippet)) {
+            || !test.tryRun("QSharedPointer<Data> baseptr; QSharedPointer<DerivedData> ptr;")) {
             sane = false;
             qWarning("Sanity checking failed\nCode:\n%s\n",
                      qPrintable(test.errorReport()));