mm/khugepaged: recover from poisoned anonymous memory

Problem
=======
Memory DIMMs are subject to multi-bit flips, i.e.  memory errors.  As
memory size and density increase, the chances of and number of memory
errors increase.  The increasing size and density of server RAM in the
data center and cloud have shown increased uncorrectable memory errors.
There are already mechanisms in the kernel to recover from uncorrectable
memory errors.  This series of patches provides the recovery mechanism for
the particular kernel agent khugepaged when it collapses memory pages.

Impact
======
The main reason we chose to make khugepaged collapsing tolerant of memory
failures was its high possibility of accessing poisoned memory while
performing functionally optional compaction actions.  Standard
applications typically don't have strict requirements on the size of its
pages.  So they are given 4K pages by the kernel.  The kernel is able to
improve application performance by either

  1) giving applications 2M pages to begin with, or
  2) collapsing 4K pages into 2M pages when possible.

This collapsing operation is done by khugepaged, a kernel agent that is
constantly scanning memory.  When collapsing 4K pages into a 2M page, it
must copy the data from the 4K pages into a physically contiguous 2M page.
Therefore, as long as there exists one poisoned cache line in collapsible
4K pages, khugepaged will eventually access it.  The current impact to
users is a machine check exception triggered kernel panic.  However,
khugepaged’s compaction operations are not functionally required kernel
actions.  Therefore making khugepaged tolerant to poisoned memory will
greatly improve user experience.

This patch series is for cases where khugepaged is the first guy that
detects the memory errors on the poisoned pages.  IOW, the pages are not
known to have memory errors when khugepaged collapsing gets to them.  In
our observation, this happens frequently when the huge page ratio of the
system is relatively low, which is fairly common in virtual machines
running on cloud.

Solution
========
As stated before, it is less desirable to crash the system only because
khugepaged accesses poisoned pages while it is collapsing 4K pages.  The
high level idea of this patch series is to skip the group of pages
(usually 512 4K-size pages) once khugepaged finds one of them is poisoned,
as these pages have become ineligible to be collapsed.

We are also careful to unwind operations khuagepaged has performed before
it detects memory failures.  For example, before copying and collapsing a
group of anonymous pages into a huge page, the source pages will be
isolated and their page table is unlinked from their PMD.  These
operations need to be undone in order to ensure these pages are not
changed/lost from the perspective of other threads (both user and kernel
space).  As for file backed memory pages, there already exists a rollback
case.  This patch just extends it so that khugepaged also correctly rolls
back when it fails to copy poisoned 4K pages.

This patch (of 3):

Make __collapse_huge_page_copy return whether copying anonymous pages
succeeded, and make collapse_huge_page handle the return status.

Break existing PTE scan loop into two for-loops.  The first loop copies
source pages into target huge page, and can fail gracefully when running
into memory errors in source pages.  If copying all pages succeeds, the
second loop releases and clears up these normal pages.  Otherwise, the
second loop rolls back the page table and page states by:

- re-establishing the original PTEs-to-PMD connection.
- releasing source pages back to their LRU list.

Tested manually:
0. Enable khugepaged on system under test.
1. Start a two-thread application. Each thread allocates a chunk of
   non-huge anonymous memory buffer.
2. Pick 4 random buffer locations (2 in each thread) and inject
   uncorrectable memory errors at corresponding physical addresses.
3. Signal both threads to make their memory buffer collapsible, i.e.
   calling madvise(MADV_HUGEPAGE).
4. Wait and check kernel log: khugepaged is able to recover from poisoned
   pages and skips collapsing them.
5. Signal both threads to inspect their buffer contents and make sure no
   data corruption.

Link: https://lkml.kernel.org/r/20230329151121.949896-1-jiaqiyan@google.com
Link: https://lkml.kernel.org/r/20230329151121.949896-2-jiaqiyan@google.com
Signed-off-by: Jiaqi Yan <jiaqiyan@google.com>
Cc: David Stevens <stevensd@chromium.org>
Cc: Hugh Dickins <hughd@google.com>
Cc: Kefeng Wang <wangkefeng.wang@huawei.com>
Cc: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
Cc: "Kirill A. Shutemov" <kirill@shutemov.name>
Cc: Miaohe Lin <linmiaohe@huawei.com>
Cc: Naoya Horiguchi <naoya.horiguchi@nec.com>
Cc: Oscar Salvador <osalvador@suse.de>
Cc: Tong Tiangen <tongtiangen@huawei.com>
Cc: Tony Luck <tony.luck@intel.com>
Cc: Yang Shi <shy828301@gmail.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>

diff --git a/include/trace/events/huge_memory.h b/include/trace/events/huge_memory.h
index c84c7af701585bd02bffbfadae389f4719a06d2a..eca4c6f3625ec15af30b9786b13985ba512c0e8f 100644 (file)
--- a/include/trace/events/huge_memory.h
+++ b/include/trace/events/huge_memory.h
@@ -37,7 +37,8 @@
        EM( SCAN_CGROUP_CHARGE_FAIL,    "ccgroup_charge_failed")        \
        EM( SCAN_TRUNCATED,             "truncated")                    \
        EM( SCAN_PAGE_HAS_PRIVATE,      "page_has_private")             \
-       EMe(SCAN_STORE_FAILED,          "store_failed")
+       EM( SCAN_STORE_FAILED,          "store_failed")                 \
+       EMe(SCAN_COPY_MC,               "copy_poisoned_page")
 
 #undef EM
 #undef EMe

diff --git a/mm/khugepaged.c b/mm/khugepaged.c
index 3b61cd188f7b09c2793bda700e60a21265be414f..c66933d8a8b8bbbbe8eb998f223a7bb256253208 100644 (file)
--- a/mm/khugepaged.c
+++ b/mm/khugepaged.c
@@ -56,6 +56,7 @@ enum scan_result {
        SCAN_TRUNCATED,
        SCAN_PAGE_HAS_PRIVATE,
        SCAN_STORE_FAILED,
+       SCAN_COPY_MC,
 };
 
 #define CREATE_TRACE_POINTS
@@ -686,20 +687,21 @@ out:
        return result;
 }
 
-static void __collapse_huge_page_copy(pte_t *pte, struct page *page,
-                                     struct vm_area_struct *vma,
-                                     unsigned long address,
-                                     spinlock_t *ptl,
-                                     struct list_head *compound_pagelist)
+static void __collapse_huge_page_copy_succeeded(pte_t *pte,
+                                               struct vm_area_struct *vma,
+                                               unsigned long address,
+                                               spinlock_t *ptl,
+                                               struct list_head *compound_pagelist)
 {
-       struct page *src_page, *tmp;
+       struct page *src_page;
+       struct page *tmp;
        pte_t *_pte;
-       for (_pte = pte; _pte < pte + HPAGE_PMD_NR;
-                               _pte++, page++, address += PAGE_SIZE) {
-               pte_t pteval = *_pte;
+       pte_t pteval;
 
+       for (_pte = pte; _pte < pte + HPAGE_PMD_NR;
+            _pte++, address += PAGE_SIZE) {
+               pteval = *_pte;
                if (pte_none(pteval) || is_zero_pfn(pte_pfn(pteval))) {
-                       clear_user_highpage(page, address);
                        add_mm_counter(vma->vm_mm, MM_ANONPAGES, 1);
                        if (is_zero_pfn(pte_pfn(pteval))) {
                                /*
@@ -711,7 +713,6 @@ static void __collapse_huge_page_copy(pte_t *pte, struct page *page,
                        }
                } else {
                        src_page = pte_page(pteval);
-                       copy_user_highpage(page, src_page, address, vma);
                        if (!PageCompound(src_page))
                                release_pte_page(src_page);
                        /*
@@ -738,6 +739,87 @@ static void __collapse_huge_page_copy(pte_t *pte, struct page *page,
        }
 }
 
+static void __collapse_huge_page_copy_failed(pte_t *pte,
+                                            pmd_t *pmd,
+                                            pmd_t orig_pmd,
+                                            struct vm_area_struct *vma,
+                                            struct list_head *compound_pagelist)
+{
+       spinlock_t *pmd_ptl;
+
+       /*
+        * Re-establish the PMD to point to the original page table
+        * entry. Restoring PMD needs to be done prior to releasing
+        * pages. Since pages are still isolated and locked here,
+        * acquiring anon_vma_lock_write is unnecessary.
+        */
+       pmd_ptl = pmd_lock(vma->vm_mm, pmd);
+       pmd_populate(vma->vm_mm, pmd, pmd_pgtable(orig_pmd));
+       spin_unlock(pmd_ptl);
+       /*
+        * Release both raw and compound pages isolated
+        * in __collapse_huge_page_isolate.
+        */
+       release_pte_pages(pte, pte + HPAGE_PMD_NR, compound_pagelist);
+}
+
+/*
+ * __collapse_huge_page_copy - attempts to copy memory contents from raw
+ * pages to a hugepage. Cleans up the raw pages if copying succeeds;
+ * otherwise restores the original page table and releases isolated raw pages.
+ * Returns SCAN_SUCCEED if copying succeeds, otherwise returns SCAN_COPY_MC.
+ *
+ * @pte: starting of the PTEs to copy from
+ * @page: the new hugepage to copy contents to
+ * @pmd: pointer to the new hugepage's PMD
+ * @orig_pmd: the original raw pages' PMD
+ * @vma: the original raw pages' virtual memory area
+ * @address: starting address to copy
+ * @ptl: lock on raw pages' PTEs
+ * @compound_pagelist: list that stores compound pages
+ */
+static int __collapse_huge_page_copy(pte_t *pte,
+                                    struct page *page,
+                                    pmd_t *pmd,
+                                    pmd_t orig_pmd,
+                                    struct vm_area_struct *vma,
+                                    unsigned long address,
+                                    spinlock_t *ptl,
+                                    struct list_head *compound_pagelist)
+{
+       struct page *src_page;
+       pte_t *_pte;
+       pte_t pteval;
+       unsigned long _address;
+       int result = SCAN_SUCCEED;
+
+       /*
+        * Copying pages' contents is subject to memory poison at any iteration.
+        */
+       for (_pte = pte, _address = address; _pte < pte + HPAGE_PMD_NR;
+            _pte++, page++, _address += PAGE_SIZE) {
+               pteval = *_pte;
+               if (pte_none(pteval) || is_zero_pfn(pte_pfn(pteval))) {
+                       clear_user_highpage(page, _address);
+                       continue;
+               }
+               src_page = pte_page(pteval);
+               if (copy_mc_user_highpage(page, src_page, _address, vma) > 0) {
+                       result = SCAN_COPY_MC;
+                       break;
+               }
+       }
+
+       if (likely(result == SCAN_SUCCEED))
+               __collapse_huge_page_copy_succeeded(pte, vma, address, ptl,
+                                                   compound_pagelist);
+       else
+               __collapse_huge_page_copy_failed(pte, pmd, orig_pmd, vma,
+                                                compound_pagelist);
+
+       return result;
+}
+
 static void khugepaged_alloc_sleep(void)
 {
        DEFINE_WAIT(wait);
@@ -1111,9 +1193,13 @@ static int collapse_huge_page(struct mm_struct *mm, unsigned long address,
         */
        anon_vma_unlock_write(vma->anon_vma);
 
-       __collapse_huge_page_copy(pte, hpage, vma, address, pte_ptl,
-                                 &compound_pagelist);
+       result = __collapse_huge_page_copy(pte, hpage, pmd, _pmd,
+                                          vma, address, pte_ptl,
+                                          &compound_pagelist);
        pte_unmap(pte);
+       if (unlikely(result != SCAN_SUCCEED))
+               goto out_up_write;
+
        /*
         * spin_lock() below is not the equivalent of smp_wmb(), but
         * the smp_wmb() inside __SetPageUptodate() can be reused to