RDMA/hns: Fix wrong assignment of qp_access_flags
authorLijun Ou <oulijun@huawei.com>
Wed, 21 Aug 2019 13:14:36 +0000 (21:14 +0800)
committerDoug Ledford <dledford@redhat.com>
Wed, 28 Aug 2019 15:57:26 +0000 (11:57 -0400)
We used wrong shifts when set qp_attr->qp_access_flag,
this patch exchange V2_QP_RRE_S and V2_QP_RWE_S to fix it.

Fixes: 2a3d923f8730 ("RDMA/hns: Replace magic numbers with #defines")
Signed-off-by: Weihang Li <liweihang@hisilicon.com>
Signed-off-by: Lijun Ou <oulijun@huawei.com>
Link: https://lore.kernel.org/r/1566393276-42555-10-git-send-email-oulijun@huawei.com
Signed-off-by: Doug Ledford <dledford@redhat.com>
drivers/infiniband/hw/hns/hns_roce_hw_v2.c

index ecd0283..7a89d66 100644 (file)
@@ -4574,9 +4574,9 @@ static int hns_roce_v2_query_qp(struct ib_qp *ibqp, struct ib_qp_attr *qp_attr,
                                                  V2_QPC_BYTE_56_DQPN_M,
                                                  V2_QPC_BYTE_56_DQPN_S);
        qp_attr->qp_access_flags = ((roce_get_bit(context.byte_76_srqn_op_en,
-                                   V2_QPC_BYTE_76_RRE_S)) << V2_QP_RWE_S) |
+                                   V2_QPC_BYTE_76_RRE_S)) << V2_QP_RRE_S) |
                                    ((roce_get_bit(context.byte_76_srqn_op_en,
-                                   V2_QPC_BYTE_76_RWE_S)) << V2_QP_RRE_S) |
+                                   V2_QPC_BYTE_76_RWE_S)) << V2_QP_RWE_S) |
                                    ((roce_get_bit(context.byte_76_srqn_op_en,
                                    V2_QPC_BYTE_76_ATE_S)) << V2_QP_ATE_S);