COMPMID-3491: ReduceMean not properly validating quantizations
authorManuel Bottini <manuel.bottini@arm.com>
Wed, 20 May 2020 14:26:36 +0000 (15:26 +0100)
committerManuel Bottini <manuel.bottini@arm.com>
Wed, 20 May 2020 17:42:08 +0000 (18:42 +0100)
Change-Id: Ia2563da7271592c4c55dde7fcecaedda6a46a781
Signed-off-by: Manuel Bottini <manuel.bottini@arm.com>
Reviewed-on: https://review.mlplatform.org/c/ml/ComputeLibrary/+/3236
Reviewed-by: Michalis Spyrou <michalis.spyrou@arm.com>
Comments-Addressed: Arm Jenkins <bsgcomp@arm.com>
Tested-by: Arm Jenkins <bsgcomp@arm.com>
src/runtime/CL/functions/CLReduceMean.cpp
src/runtime/NEON/functions/NEReduceMean.cpp

index 3ddaa00d4b4b2a5674bb4295295d60848a2ab1a7..ce447636ec03275684de8e14417675046b849155 100644 (file)
@@ -83,6 +83,7 @@ Status validate_config(const ITensorInfo *input, const Coordinates &reduction_ax
         }
         const TensorInfo out_info = input->clone()->set_tensor_shape(out_shape);
         ARM_COMPUTE_RETURN_ERROR_ON_MISMATCHING_SHAPES(output, &out_info);
+        ARM_COMPUTE_RETURN_ERROR_ON_MISMATCHING_QUANTIZATION_INFO(input, output);
     }
     return Status{};
 }
index 5c936af562bc856ddfc3ae4771832671e9214c75..d53ed3164539dc0c6509a4f0cece988fa94725af 100644 (file)
@@ -89,6 +89,7 @@ Status validate_config(const ITensorInfo *input, const Coordinates &reduction_ax
         }
         const TensorInfo out_info = input->clone()->set_tensor_shape(out_shape);
         ARM_COMPUTE_RETURN_ERROR_ON_MISMATCHING_SHAPES(output, &out_info);
+        ARM_COMPUTE_RETURN_ERROR_ON_MISMATCHING_QUANTIZATION_INFO(input, output);
     }
     return Status{};
 }