bpf, test_run: Remove unnecessary prog type checks
authorDaniel Xu <dxu@dxuuu.xyz>
Sun, 29 May 2022 20:15:41 +0000 (15:15 -0500)
committerAndrii Nakryiko <andrii@kernel.org>
Fri, 3 Jun 2022 21:53:33 +0000 (14:53 -0700)
These checks were effectively noops b/c there's only one way these
functions get called: through prog_ops dispatching. And since there's no
other callers, we can be sure that `prog` is always the correct type.

Signed-off-by: Daniel Xu <dxu@dxuuu.xyz>
Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
Signed-off-by: Andrii Nakryiko <andrii@kernel.org>
Acked-by: Song Liu <songliubraving@fb.com>
Link: https://lore.kernel.org/bpf/0a9aaac329f76ddb17df1786b001117823ffefa5.1653855302.git.dxu@dxuuu.xyz
net/bpf/test_run.c

index 56f059b..2ca96ac 100644 (file)
@@ -1420,9 +1420,6 @@ int bpf_prog_test_run_flow_dissector(struct bpf_prog *prog,
        void *data;
        int ret;
 
-       if (prog->type != BPF_PROG_TYPE_FLOW_DISSECTOR)
-               return -EINVAL;
-
        if (kattr->test.flags || kattr->test.cpu || kattr->test.batch_size)
                return -EINVAL;
 
@@ -1487,9 +1484,6 @@ int bpf_prog_test_run_sk_lookup(struct bpf_prog *prog, const union bpf_attr *kat
        u32 retval, duration;
        int ret = -EINVAL;
 
-       if (prog->type != BPF_PROG_TYPE_SK_LOOKUP)
-               return -EINVAL;
-
        if (kattr->test.flags || kattr->test.cpu || kattr->test.batch_size)
                return -EINVAL;