net: phy: call phy_disable_interrupts() in phy_init_hw()
authorJisheng Zhang <Jisheng.Zhang@synaptics.com>
Wed, 24 Jun 2020 07:59:23 +0000 (15:59 +0800)
committerDavid S. Miller <davem@davemloft.net>
Wed, 24 Jun 2020 21:52:49 +0000 (14:52 -0700)
Call phy_disable_interrupts() in phy_init_hw() to "have a defined init
state as we don't know in which state the PHY is if the PHY driver is
loaded. We shouldn't assume that it's the chip power-on defaults, BIOS
or boot loader could have changed this. Or in case of dual-boot
systems the other OS could leave the PHY in whatever state." as pointed
out by Heiner.

Suggested-by: Heiner Kallweit <hkallweit1@gmail.com>
Signed-off-by: Jisheng Zhang <Jisheng.Zhang@synaptics.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/phy/phy_device.c

index 85ba95b598b5e298dcd447ddfea7db50085c0248..b4978c5fb2ca8ac0c47c8ca56a51cee27fbf5086 100644 (file)
@@ -1092,6 +1092,10 @@ int phy_init_hw(struct phy_device *phydev)
        if (ret < 0)
                return ret;
 
+       ret = phy_disable_interrupts(phydev);
+       if (ret)
+               return ret;
+
        if (phydev->drv->config_init)
                ret = phydev->drv->config_init(phydev);