x86/power: Optimize C3 entry on Centaur CPUs
authorDavid Wang <davidwang@zhaoxin.com>
Thu, 27 Dec 2018 08:41:50 +0000 (16:41 +0800)
committerIngo Molnar <mingo@kernel.org>
Fri, 19 Apr 2019 17:28:06 +0000 (19:28 +0200)
For new Centaur CPUs the ucode will take care of the preservation of cache coherence
between CPU cores in C-states regardless of how deep the C-states are. So, it is not
necessary to flush the caches in software befor entering C3. This useless operation
will cause performance drop for the cores which share some caches with the idling core.

Signed-off-by: David Wang <davidwang@zhaoxin.com>
Reviewed-by: Thomas Gleixner <tglx@linutronix.de>
Acked-by: Pavel Machek <pavel@ucw.cz>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: brucechang@via-alliance.com
Cc: cooperyan@zhaoxin.com
Cc: len.brown@intel.com
Cc: linux-pm@kernel.org
Cc: qiyuanwang@zhaoxin.com
Cc: rjw@rjwysocki.net
Cc: timguo@zhaoxin.com
Link: http://lkml.kernel.org/r/1545900110-2757-1-git-send-email-davidwang@zhaoxin.com
[ Tidy up the comment. ]
Signed-off-by: Ingo Molnar <mingo@kernel.org>
arch/x86/kernel/acpi/cstate.c

index 158ad14..cb6e076 100644 (file)
@@ -51,6 +51,18 @@ void acpi_processor_power_init_bm_check(struct acpi_processor_flags *flags,
        if (c->x86_vendor == X86_VENDOR_INTEL &&
            (c->x86 > 0xf || (c->x86 == 6 && c->x86_model >= 0x0f)))
                        flags->bm_control = 0;
+       /*
+        * For all recent Centaur CPUs, the ucode will make sure that each
+        * core can keep cache coherence with each other while entering C3
+        * type state. So, set bm_check to 1 to indicate that the kernel
+        * doesn't need to execute a cache flush operation (WBINVD) when
+        * entering C3 type state.
+        */
+       if (c->x86_vendor == X86_VENDOR_CENTAUR) {
+               if (c->x86 > 6 || (c->x86 == 6 && c->x86_model == 0x0f &&
+                   c->x86_stepping >= 0x0e))
+                       flags->bm_check = 1;
+       }
 }
 EXPORT_SYMBOL(acpi_processor_power_init_bm_check);