slimbus: ngd: register ngd driver only once.
authorSrinivas Kandagatla <srinivas.kandagatla@linaro.org>
Sun, 16 Sep 2018 23:45:46 +0000 (16:45 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 20 Nov 2019 17:47:29 +0000 (18:47 +0100)
[ Upstream commit 1830dad34c070161fda2ff1db77b39ffa78aa380 ]

Move ngd platform driver out of loop so that it registers only once.

Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/slimbus/qcom-ngd-ctrl.c

index f63d1b8..a9abde2 100644 (file)
@@ -1346,7 +1346,6 @@ static int of_qcom_slim_ngd_register(struct device *parent,
                ngd->base = ctrl->base + ngd->id * data->offset +
                                        (ngd->id - 1) * data->size;
                ctrl->ngd = ngd;
-               platform_driver_register(&qcom_slim_ngd_driver);
 
                return 0;
        }
@@ -1445,6 +1444,7 @@ static int qcom_slim_ngd_ctrl_probe(struct platform_device *pdev)
        init_completion(&ctrl->reconf);
        init_completion(&ctrl->qmi.qmi_comp);
 
+       platform_driver_register(&qcom_slim_ngd_driver);
        return of_qcom_slim_ngd_register(dev, ctrl);
 }