ASoC: hdmi-codec.c: use devm_kzalloc() for DMA data
authorKuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Fri, 9 Sep 2022 01:20:48 +0000 (01:20 +0000)
committerMark Brown <broonie@kernel.org>
Fri, 9 Sep 2022 21:27:08 +0000 (22:27 +0100)
hdmi-codec.c is using kzalloc(), but we can replace it to
devm_kzalloc() and then, we can remove .remove callback.

Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Reviewed-by: Charles Keepax <ckeepax@opensource.cirrus.com>
Link: https://lore.kernel.org/r/874jxhmjgw.wl-kuninori.morimoto.gx@renesas.com
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/codecs/hdmi-codec.c

index 863e679d2ac117f3b92133f7836cc38cb3653392..0b1cdb2d60498e37ca239923a535402a6ac558aa 100644 (file)
@@ -823,7 +823,7 @@ static int hdmi_dai_probe(struct snd_soc_dai *dai)
        if (ret)
                return ret;
 
-       daifmt = kzalloc(sizeof(*daifmt), GFP_KERNEL);
+       daifmt = devm_kzalloc(dai->dev, sizeof(*daifmt), GFP_KERNEL);
        if (!daifmt)
                return -ENOMEM;
 
@@ -890,17 +890,10 @@ static int hdmi_dai_spdif_probe(struct snd_soc_dai *dai)
        return 0;
 }
 
-static int hdmi_codec_dai_remove(struct snd_soc_dai *dai)
-{
-       kfree(dai->playback_dma_data);
-       return 0;
-}
-
 static const struct snd_soc_dai_driver hdmi_i2s_dai = {
        .name = "i2s-hifi",
        .id = DAI_ID_I2S,
        .probe = hdmi_dai_probe,
-       .remove = hdmi_codec_dai_remove,
        .playback = {
                .stream_name = "I2S Playback",
                .channels_min = 2,
@@ -925,7 +918,6 @@ static const struct snd_soc_dai_driver hdmi_spdif_dai = {
        .name = "spdif-hifi",
        .id = DAI_ID_SPDIF,
        .probe = hdmi_dai_spdif_probe,
-       .remove = hdmi_codec_dai_remove,
        .playback = {
                .stream_name = "SPDIF Playback",
                .channels_min = 2,