efi_selftest: Do not check EFI_SIMPLE_NETWORK_RECEIVE_INTERRUPT
authorMasami Hiramatsu <masami.hiramatsu@linaro.org>
Thu, 16 Sep 2021 08:53:36 +0000 (17:53 +0900)
committerHeinrich Schuchardt <xypron.glpk@gmx.de>
Thu, 21 Oct 2021 01:46:03 +0000 (03:46 +0200)
Do not check EFI_SIMPLE_NETWORK_RECEIVE_INTERRUPT in packet
receiving loop. This depends on the implementation and not
related to whether the packet can be received or not.

Whether the received packets are available or not is ensured
by wait_for_packet, and that is already done in the loop.

Signed-off-by: Masami Hiramatsu <masami.hiramatsu@linaro.org>
Reviewed-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
lib/efi_selftest/efi_selftest_snp.c

index cb0db7e..c5366c8 100644 (file)
@@ -340,8 +340,6 @@ static int execute(void)
        events[0] = timer;
        events[1] = net->wait_for_packet;
        for (;;) {
-               u32 int_status;
-
                /*
                 * Wait for packet to be received or timer event.
                 */
@@ -367,15 +365,6 @@ static int execute(void)
                 * Receive packet
                 */
                buffer_size = sizeof(buffer);
-               ret = net->get_status(net, &int_status, NULL);
-               if (ret != EFI_SUCCESS) {
-                       efi_st_error("Failed to get status");
-                       return EFI_ST_FAILURE;
-               }
-               if (!(int_status & EFI_SIMPLE_NETWORK_RECEIVE_INTERRUPT)) {
-                       efi_st_error("RX interrupt not set");
-                       return EFI_ST_FAILURE;
-               }
                ret = net->receive(net, NULL, &buffer_size, &buffer,
                                   &srcaddr, &destaddr, NULL);
                if (ret != EFI_SUCCESS) {