projects
/
platform
/
upstream
/
llvm.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
2d8c289
)
[ValueTracking] remove TODO comment; NFC
author
Sanjay Patel
<spatel@rotateright.com>
Tue, 1 Nov 2016 20:43:00 +0000
(20:43 +0000)
committer
Sanjay Patel
<spatel@rotateright.com>
Tue, 1 Nov 2016 20:43:00 +0000
(20:43 +0000)
InstCombine should always canonicalize patterns like the one shown in the comment
when visiting 'select' insts in adjustMinMax().
Scalars were already handled there, and vector splats are handled after:
https://reviews.llvm.org/rL285732
llvm-svn: 285744
llvm/lib/Analysis/ValueTracking.cpp
patch
|
blob
|
history
diff --git
a/llvm/lib/Analysis/ValueTracking.cpp
b/llvm/lib/Analysis/ValueTracking.cpp
index
f1b91d2
..
c8cba38
100644
(file)
--- a/
llvm/lib/Analysis/ValueTracking.cpp
+++ b/
llvm/lib/Analysis/ValueTracking.cpp
@@
-3991,8
+3991,6
@@
static SelectPatternResult matchSelectPattern(CmpInst::Predicate Pred,
}
}
- // TODO: (X > 4) ? X : 5 --> (X >= 5) ? X : 5 --> MAX(X, 5)
-
return {SPF_UNKNOWN, SPNB_NA, false};
}