powerpc/83xx/mpc832x_rdb: call platform_device_put() in error case in of_fsl_spi_probe()
authorYang Yingliang <yangyingliang@huawei.com>
Sat, 29 Oct 2022 11:16:26 +0000 (19:16 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 31 Dec 2022 12:32:51 +0000 (13:32 +0100)
[ Upstream commit 4d0eea415216fe3791da2f65eb41399e70c7bedf ]

If platform_device_add() is not called or failed, it can not call
platform_device_del() to clean up memory, it should call
platform_device_put() in error case.

Fixes: 26f6cb999366 ("[POWERPC] fsl_soc: add support for fsl_spi")
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Link: https://lore.kernel.org/r/20221029111626.429971-1-yangyingliang@huawei.com
Signed-off-by: Sasha Levin <sashal@kernel.org>
arch/powerpc/platforms/83xx/mpc832x_rdb.c

index e12cb44..caa96ed 100644 (file)
@@ -107,7 +107,7 @@ static int __init of_fsl_spi_probe(char *type, char *compatible, u32 sysclk,
 
                goto next;
 unreg:
-               platform_device_del(pdev);
+               platform_device_put(pdev);
 err:
                pr_err("%pOF: registration failed\n", np);
 next: