power: supply: Use IRQF_ONESHOT
authordongjian <dongjian@yulong.com>
Mon, 22 Mar 2021 11:21:33 +0000 (19:21 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 11 May 2021 12:47:24 +0000 (14:47 +0200)
[ Upstream commit 2469b836fa835c67648acad17d62bc805236a6ea ]

Fixes coccicheck error:

drivers/power/supply/pm2301_charger.c:1089:7-27: ERROR:
drivers/power/supply/lp8788-charger.c:502:8-28: ERROR:
drivers/power/supply/tps65217_charger.c:239:8-33: ERROR:
drivers/power/supply/tps65090-charger.c:303:8-33: ERROR:

Threaded IRQ with no primary handler requested without IRQF_ONESHOT

Signed-off-by: dongjian <dongjian@yulong.com>
Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/power/supply/lp8788-charger.c
drivers/power/supply/pm2301_charger.c
drivers/power/supply/tps65090-charger.c
drivers/power/supply/tps65217_charger.c

index e7931ff..397e5a0 100644 (file)
@@ -501,7 +501,7 @@ static int lp8788_set_irqs(struct platform_device *pdev,
 
                ret = request_threaded_irq(virq, NULL,
                                        lp8788_charger_irq_thread,
-                                       0, name, pchg);
+                                       IRQF_ONESHOT, name, pchg);
                if (ret)
                        break;
        }
index 2df6a24..34f168f 100644 (file)
@@ -1090,7 +1090,7 @@ static int pm2xxx_wall_charger_probe(struct i2c_client *i2c_client,
        ret = request_threaded_irq(gpio_to_irq(pm2->pdata->gpio_irq_number),
                                NULL,
                                pm2xxx_charger_irq[0].isr,
-                               pm2->pdata->irq_type,
+                               pm2->pdata->irq_type | IRQF_ONESHOT,
                                pm2xxx_charger_irq[0].name, pm2);
 
        if (ret != 0) {
index 6b0098e..0990b2f 100644 (file)
@@ -301,7 +301,7 @@ static int tps65090_charger_probe(struct platform_device *pdev)
 
        if (irq != -ENXIO) {
                ret = devm_request_threaded_irq(&pdev->dev, irq, NULL,
-                       tps65090_charger_isr, 0, "tps65090-charger", cdata);
+                       tps65090_charger_isr, IRQF_ONESHOT, "tps65090-charger", cdata);
                if (ret) {
                        dev_err(cdata->dev,
                                "Unable to register irq %d err %d\n", irq,
index 814c2b8..ba33d16 100644 (file)
@@ -238,7 +238,7 @@ static int tps65217_charger_probe(struct platform_device *pdev)
        for (i = 0; i < NUM_CHARGER_IRQS; i++) {
                ret = devm_request_threaded_irq(&pdev->dev, irq[i], NULL,
                                                tps65217_charger_irq,
-                                               0, "tps65217-charger",
+                                               IRQF_ONESHOT, "tps65217-charger",
                                                charger);
                if (ret) {
                        dev_err(charger->dev,