Add comment to justify AllowDeferredHandleDereference in WeakCell factory.
authorulan <ulan@chromium.org>
Wed, 29 Apr 2015 08:36:05 +0000 (01:36 -0700)
committerCommit bot <commit-bot@chromium.org>
Wed, 29 Apr 2015 08:36:11 +0000 (08:36 +0000)
BUG=

Review URL: https://codereview.chromium.org/1110373002

Cr-Commit-Position: refs/heads/master@{#28123}

src/factory.cc

index d2a8d79..133f74d 100644 (file)
@@ -942,6 +942,8 @@ Handle<PropertyCell> Factory::NewPropertyCell() {
 
 
 Handle<WeakCell> Factory::NewWeakCell(Handle<HeapObject> value) {
+  // It is safe to dereference the value because we are embedding it
+  // in cell and not inspecting its fields.
   AllowDeferredHandleDereference convert_to_cell;
   CALL_HEAP_FUNCTION(isolate(), isolate()->heap()->AllocateWeakCell(*value),
                      WeakCell);