io_uring: add likely/unlikely in io_get_sqring()
authorPavel Begunkov <asml.silence@gmail.com>
Thu, 21 Nov 2019 18:24:56 +0000 (21:24 +0300)
committerJens Axboe <axboe@kernel.dk>
Tue, 26 Nov 2019 02:56:10 +0000 (19:56 -0700)
The number of SQEs to submit is specified by a user, so io_get_sqring()
in most of the cases succeeds. Hint compilers about that.

Checking ASM genereted by gcc 9.2.0 for x64, there is one branch
misprediction.

Signed-off-by: Pavel Begunkov <asml.silence@gmail.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
fs/io_uring.c

index 956a61c..63e0448 100644 (file)
@@ -3129,11 +3129,11 @@ static bool io_get_sqring(struct io_ring_ctx *ctx, struct sqe_submit *s)
         */
        head = ctx->cached_sq_head;
        /* make sure SQ entry isn't read before tail */
-       if (head == smp_load_acquire(&rings->sq.tail))
+       if (unlikely(head == smp_load_acquire(&rings->sq.tail)))
                return false;
 
        head = READ_ONCE(sq_array[head & ctx->sq_mask]);
-       if (head < ctx->sq_entries) {
+       if (likely(head < ctx->sq_entries)) {
                s->ring_file = NULL;
                s->sqe = &ctx->sq_sqes[head];
                s->sequence = ctx->cached_sq_head;