Support StorageClass PushConstant
authorDavid Neto <dneto@google.com>
Wed, 23 Sep 2015 14:19:57 +0000 (10:19 -0400)
committerDavid Neto <dneto@google.com>
Mon, 26 Oct 2015 16:55:33 +0000 (12:55 -0400)
source/operand.cpp
test/TextToBinary.Memory.cpp

index 1b995c4..962f396 100644 (file)
@@ -345,6 +345,11 @@ static const spv_operand_desc_t storageClassEntries[] = {
      SPV_OPCODE_FLAGS_CAPABILITIES,
      CapabilityKernel,
      {SPV_OPERAND_TYPE_NONE}},
+    {"PushConstant",
+     StorageClassPushConstant,
+     SPV_OPCODE_FLAGS_CAPABILITIES,
+     CapabilityShader,
+     {SPV_OPERAND_TYPE_NONE}},
     {"AtomicCounter",
      StorageClassAtomicCounter,
      SPV_OPCODE_FLAGS_CAPABILITIES,
index df53b43..892984c 100644 (file)
@@ -89,7 +89,6 @@ TEST_P(StorageClassTest, AnyStorageClass) {
 INSTANTIATE_TEST_CASE_P(
     TextToBinaryStorageClassTest, StorageClassTest,
     ::testing::ValuesIn(std::vector<EnumCase<spv::StorageClass>>{
-        // TODO(dneto): There are more storage classes in Rev32 and later.
         CASE(UniformConstant),
         CASE(Input),
         CASE(Uniform),
@@ -99,6 +98,7 @@ INSTANTIATE_TEST_CASE_P(
         CASE(PrivateGlobal),
         CASE(Function),
         CASE(Generic),
+        CASE(PushConstant),
         CASE(AtomicCounter),
         CASE(Image),
     }));