Fix prevent issue : dereference before null check 42/33542/1
authorWonkeun Oh <wonkeun.oh@samsung.com>
Mon, 26 May 2014 11:31:42 +0000 (20:31 +0900)
committerLi Zhang <li2012.zhang@samsung.com>
Mon, 12 Jan 2015 06:30:55 +0000 (14:30 +0800)
[model] Redwood, B1, B2
[binary_type] PDA
[customer] OPEN
[issue#] N/A
[problem] prevent issue: dereference before null check
[cause] dereference before null check
[solution] added null check code
[team] Input Framework
[request] N/A
[horizontal_expansion] N/A

Change-Id: I4fe9af0662c7c8a0a409e372f83e9746e0950f70

ism/extras/efl_panel/isf_panel_efl.cpp

index eeda8ce..754086f 100644 (file)
@@ -1073,7 +1073,7 @@ static bool get_helper_ise_info (const char *type, const char *package, HelperIn
 
     package_info_foreach_app_from_package (pkg_info, PACKAGE_INFO_UIAPP, app_info_cb, helper_info);
 
-    if (helper_info->uuid.length ()  > 0) {
+    if (pkg_label && pkg_icon_path && (helper_info->uuid.length ()  > 0)) {
         helper_info->name = String (pkg_label);
         helper_info->icon = String (pkg_icon_path);
         helper_info->option = SCIM_HELPER_STAND_ALONE | SCIM_HELPER_NEED_SCREEN_INFO | SCIM_HELPER_NEED_SPOT_LOCATION_INFO | SCIM_HELPER_AUTO_RESTART;