libusbgx: Add parenthesis to INSERT_TAILQ_STRING_ORDER macro.
authorKrzysztof Opasiak <k.opasiak@samsung.com>
Thu, 27 Feb 2014 14:23:05 +0000 (15:23 +0100)
committerKrzysztof Opasiak <k.opasiak@samsung.com>
Tue, 22 Dec 2015 19:35:21 +0000 (20:35 +0100)
Surround each pointer in macro with parenthesis to avid
errors related to operator precedence.

Signed-off-by: Krzysztof Opasiak <k.opasiak@samsung.com>
[Port from libusbg and update description]
Signed-off-by: Krzysztof Opasiak <k.opasiak@samsung.com>
src/usbg.c

index 55e44c2..b6aa80d 100644 (file)
@@ -118,17 +118,17 @@ const char *function_names[] =
 /* Insert in string order */
 #define INSERT_TAILQ_STRING_ORDER(HeadPtr, HeadType, NameField, ToInsert, NodeField) \
        do { \
-               if (TAILQ_EMPTY(HeadPtr) || \
-                       (strcmp(ToInsert->NameField, TAILQ_FIRST(HeadPtr)->NameField) < 0)) \
-                       TAILQ_INSERT_HEAD(HeadPtr, ToInsert, NodeField); \
-               else if (strcmp(ToInsert->NameField, TAILQ_LAST(HeadPtr, HeadType)->NameField) > 0) \
-                       TAILQ_INSERT_TAIL(HeadPtr, ToInsert, NodeField); \
+               if (TAILQ_EMPTY((HeadPtr)) || \
+                       (strcmp((ToInsert)->NameField, TAILQ_FIRST((HeadPtr))->NameField) < 0)) \
+                       TAILQ_INSERT_HEAD((HeadPtr), (ToInsert), NodeField); \
+               else if (strcmp((ToInsert)->NameField, TAILQ_LAST((HeadPtr), HeadType)->NameField) > 0) \
+                       TAILQ_INSERT_TAIL((HeadPtr), (ToInsert), NodeField); \
                else { \
                        typeof(ToInsert) _cur; \
-                       TAILQ_FOREACH(_cur, HeadPtr, NodeField) { \
-                               if (strcmp(ToInsert->NameField, _cur->NameField) > 0) \
+                       TAILQ_FOREACH(_cur, (HeadPtr), NodeField) { \
+                               if (strcmp((ToInsert)->NameField, _cur->NameField) > 0) \
                                        continue; \
-                               TAILQ_INSERT_BEFORE(_cur, ToInsert, NodeField); \
+                               TAILQ_INSERT_BEFORE(_cur, (ToInsert), NodeField); \
                        } \
                } \
        } while (0)